Skip to content

Add workerConnections field to helm chart #3616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sarthyparty
Copy link
Contributor

@sarthyparty sarthyparty commented Jul 10, 2025

Proposed changes

Add workerConnections field to helm chart

Problem: workerConnections was not able to be configured by helm

Solution: I added the field to the schema.

Testing: I tested a new helm chart with workerConnections set to 2048 and saw that the NginxProxy resource had the correct value and the worker connections field appeared in the conf as well.

Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.

Closes #ISSUE

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.


@sarthyparty sarthyparty requested a review from a team as a code owner July 10, 2025 18:38
@github-actions github-actions bot added enhancement New feature or request helm-chart Relates to helm chart labels Jul 10, 2025
@sarthyparty sarthyparty force-pushed the feature/add-worker-connections-to-helm branch from 63bbb0b to 92f6466 Compare July 10, 2025 18:38
@sarthyparty sarthyparty force-pushed the feature/add-worker-connections-to-helm branch 2 times, most recently from cedbbec to 38510ab Compare July 10, 2025 18:57
@sarthyparty sarthyparty requested a review from sjberman July 10, 2025 18:58
@sarthyparty sarthyparty enabled auto-merge (squash) July 10, 2025 19:01
@sarthyparty sarthyparty force-pushed the feature/add-worker-connections-to-helm branch from 38510ab to 15e9885 Compare July 10, 2025 19:03
@sarthyparty sarthyparty merged commit 487dbe6 into nginx:main Jul 10, 2025
48 checks passed
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request helm-chart Relates to helm chart
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants